Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented Aug 31, 2025

This PR adds a few tests that should help restoring a higher coverage

@mwouts mwouts added this to the 2.5.0 milestone Aug 31, 2025
@github-actions
Copy link

github-actions bot commented Aug 31, 2025

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation.
Download it here, unzip it and then run pip install itables-xxx.whl in the unzipped directory.

@mwouts mwouts force-pushed the increase_coverage branch 3 times, most recently from e2eb5c7 to 6682ab6 Compare August 31, 2025 20:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.27%. Comparing base (3c83bd7) to head (b834945).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/dt_for_itables/add_host_to_root.py 90.90% 1 Missing ⚠️
tests/test_documentation_notebooks_run.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   88.03%   94.27%   +6.23%     
==========================================
  Files          52       41      -11     
  Lines        2106     1833     -273     
==========================================
- Hits         1854     1728     -126     
+ Misses        252      105     -147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts mwouts force-pushed the increase_coverage branch 4 times, most recently from b73d074 to b900966 Compare August 31, 2025 21:06
@mwouts mwouts force-pushed the increase_coverage branch from b900966 to b834945 Compare August 31, 2025 21:16
@mwouts mwouts merged commit d8d6ecc into main Aug 31, 2025
14 checks passed
@mwouts mwouts deleted the increase_coverage branch August 31, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants